diff --git a/htdocs/expedition/liste.php b/htdocs/expedition/liste.php index 54a29a21dc6..d4f3f32af48 100644 --- a/htdocs/expedition/liste.php +++ b/htdocs/expedition/liste.php @@ -37,7 +37,7 @@ $result = restrictedArea($user, 'expedition',$expeditionid,''); $sortfield=isset($_GET["sortfield"])?$_GET["sortfield"]:""; $sortorder=isset($_GET["sortorder"])?$_GET["sortorder"]:""; -if (! $sortfield) $sortfield="e.rowid"; +if (! $sortfield) $sortfield="e.ref"; if (! $sortorder) $sortorder="DESC"; $limit = $conf->liste_limit; @@ -53,24 +53,17 @@ llxHeader('',$langs->trans('ListOfSendings'),$helpurl); $sql = "SELECT e.rowid, e.ref,".$db->pdate("e.date_expedition")." as date_expedition, e.fk_statut"; $sql.= ", s.nom as socname, s.rowid as socid"; -$sql.= ", ori.ref as origin_ref, ori.rowid as origin_id"; -$sql.= " FROM ".MAIN_DB_PREFIX."expedition as e"; -$sql.= " LEFT JOIN ".MAIN_DB_PREFIX."element_element as el ON e.rowid = el.fk_target"; -if ($conf->commande->enabled) +$sql.= " FROM (".MAIN_DB_PREFIX."expedition as e"; +if (!$user->rights->societe->client->voir && !$socid) // Internal user with no permission to see all { - $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."commande as ori ON el.fk_source = ori.rowid"; - $sql.= " AND el.sourcetype = 'commande'"; -} -else -{ - $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."propal as ori ON el.fk_source = ori.rowid"; - $sql.= " AND el.sourcetype = 'propal'"; + $sql.= ", ".MAIN_DB_PREFIX."societe_commerciaux as sc"; } +$sql.= ")"; $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON s.rowid = e.fk_soc"; $sql.= " WHERE e.entity = ".$conf->entity; -if (!$user->rights->societe->client->voir && !$socid) +if (!$user->rights->societe->client->voir && !$socid) // Internal user with no permission to see all { - $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON e.fk_soc = sc.fk_soc"; + $sql.= " AND e.fk_soc = sc.fk_soc"; $sql.= " AND sc.fk_user = " .$user->id; } if ($socid) @@ -100,15 +93,7 @@ if ($resql) print '