From d74776622d87b8361923bb4e166c2621a77259b8 Mon Sep 17 00:00:00 2001
From: Marc de Lima Lucio <68746600+marc-dll@users.noreply.github.com>
Date: Thu, 30 Sep 2021 12:57:00 +0200
Subject: [PATCH] NEW: deposit payment terms: check invoice module activation +
 rights

---
 htdocs/comm/propal/card.php | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/htdocs/comm/propal/card.php b/htdocs/comm/propal/card.php
index 6cdcb94e169..039b8fc25ec 100644
--- a/htdocs/comm/propal/card.php
+++ b/htdocs/comm/propal/card.php
@@ -687,7 +687,12 @@ if (empty($reshook)) {
 				$deposit = null;
 				$locationTarget = $_SERVER['PHP_SELF'] . '?id=' . $object->id;
 
-				if (!$error && GETPOST('statut', 'int') == $object::STATUS_SIGNED && GETPOST('generate_deposit', 'int') > 0) {
+				$deposit_percent_from_payment_terms = getDictvalue(MAIN_DB_PREFIX . 'c_payment_term', 'deposit_percent', $object->cond_reglement_id);
+
+				if (
+					!$error && GETPOST('statut', 'int') == $object::STATUS_SIGNED && GETPOST('generate_deposit', 'int') > 0
+					&& ! empty($deposit_percent_from_payment_terms) && ! empty($conf->facture->enabled) && ! empty($user->rights->facture->creer)
+				) {
 					$deposit = Facture::createDepositFromOrigin($object, $user, 0, GETPOST('validate_generated_deposit', 'int') > 0);
 
 					if ($deposit) {
@@ -1971,7 +1976,7 @@ if ($action == 'create') {
 
 		$deposit_percent_from_payment_terms = getDictvalue(MAIN_DB_PREFIX . 'c_payment_term', 'deposit_percent', $object->cond_reglement_id);
 
-		if (! empty($deposit_percent_from_payment_terms)) {
+		if (! empty($deposit_percent_from_payment_terms) && ! empty($conf->facture->enabled) && ! empty($user->rights->facture->creer)) {
 			$object->fetchObjectLinked();
 
 			$eligibleForDepositGeneration = true;
@@ -2032,7 +2037,7 @@ if ($action == 'create') {
 					'
 				);
 			}
-		}
+        }
 
 		if (!empty($conf->notification->enabled)) {
 			require_once DOL_DOCUMENT_ROOT.'/core/class/notify.class.php';