From d7cc1bdc88aa6bc9cf6798effa3f365b5a40f990 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Sun, 19 Feb 2012 19:14:17 +0100
Subject: [PATCH] Uniformize code

---
 htdocs/admin/security.php        | 22 ++++++++++++----------
 htdocs/core/lib/security.lib.php | 15 +++++++++------
 2 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/htdocs/admin/security.php b/htdocs/admin/security.php
index 89c592cb9ff..5b9622d9f49 100644
--- a/htdocs/admin/security.php
+++ b/htdocs/admin/security.php
@@ -26,6 +26,8 @@ require("../main.inc.php");
 require_once(DOL_DOCUMENT_ROOT."/core/lib/admin.lib.php");
 require_once(DOL_DOCUMENT_ROOT."/core/lib/security2.lib.php");
 
+$action=GETPOST('action');
+
 $langs->load("users");
 $langs->load("admin");
 $langs->load("other");
@@ -41,7 +43,7 @@ $mesg = '';
 /*
  * Actions
  */
-if ($_GET["action"] == 'setgeneraterule')
+if ($action == 'setgeneraterule')
 {
 	if (! dolibarr_set_const($db, 'USER_PASSWORD_GENERATED',$_GET["value"],'chaine',0,'',$conf->entity))
 	{
@@ -54,7 +56,7 @@ if ($_GET["action"] == 'setgeneraterule')
 	}
 }
 
-if ($_GET["action"] == 'activate_encrypt')
+if ($action == 'activate_encrypt')
 {
     $error=0;
 
@@ -109,7 +111,7 @@ if ($_GET["action"] == 'activate_encrypt')
 		dol_print_error($db,'');
 	}
 }
-else if ($_GET["action"] == 'disable_encrypt')
+else if ($action == 'disable_encrypt')
 {
 	//On n'autorise pas l'annulation de l'encryption car les mots de passe ne peuvent pas etre decodes
 	//Do not allow "disable encryption" as passwords cannot be decrypted
@@ -121,7 +123,7 @@ else if ($_GET["action"] == 'disable_encrypt')
     exit;
 }
 
-if ($_GET["action"] == 'activate_encryptdbpassconf')
+if ($action == 'activate_encryptdbpassconf')
 {
 	$result = encodedecode_dbpassconf(1);
 	if ($result > 0)
@@ -136,7 +138,7 @@ if ($_GET["action"] == 'activate_encryptdbpassconf')
 		$mesg='<div class="warning">'.$langs->trans('InstrucToEncodePass',dol_encode($dolibarr_main_db_pass)).'</div>';
 	}
 }
-else if ($_GET["action"] == 'disable_encryptdbpassconf')
+else if ($action == 'disable_encryptdbpassconf')
 {
 	$result = encodedecode_dbpassconf(0);
 	if ($result > 0)
@@ -152,26 +154,26 @@ else if ($_GET["action"] == 'disable_encryptdbpassconf')
 	}
 }
 
-if ($_GET["action"] == 'activate_pdfsecurity')
+if ($action == 'activate_pdfsecurity')
 {
 	dolibarr_set_const($db, "PDF_SECURITY_ENCRYPTION", "1",'chaine',0,'',$conf->entity);
 	Header("Location: security.php");
 	exit;
 }
-else if ($_GET["action"] == 'disable_pdfsecurity')
+else if ($action == 'disable_pdfsecurity')
 {
 	dolibarr_del_const($db, "PDF_SECURITY_ENCRYPTION",$conf->entity);
 	Header("Location: security.php");
 	exit;
 }
 
-if ($_GET["action"] == 'activate_MAIN_SECURITY_DISABLEFORGETPASSLINK')
+if ($action == 'activate_MAIN_SECURITY_DISABLEFORGETPASSLINK')
 {
 	dolibarr_set_const($db, "MAIN_SECURITY_DISABLEFORGETPASSLINK", '1','chaine',0,'',$conf->entity);
 	Header("Location: security.php");
 	exit;
 }
-else if ($_GET["action"] == 'disable_MAIN_SECURITY_DISABLEFORGETPASSLINK')
+else if ($action == 'disable_MAIN_SECURITY_DISABLEFORGETPASSLINK')
 {
 	dolibarr_del_const($db, "MAIN_SECURITY_DISABLEFORGETPASSLINK",$conf->entity);
 	Header("Location: security.php");
@@ -190,7 +192,7 @@ llxHeader('',$langs->trans("Passwords"));
 
 print_fiche_titre($langs->trans("SecuritySetup"),'','setup');
 
-if ($mesg) print $mesg."<br>\n";
+dol_htmloutput_mesg($mesg);
 
 print $langs->trans("GeneratedPasswordDesc")."<br>\n";
 print "<br>\n";
diff --git a/htdocs/core/lib/security.lib.php b/htdocs/core/lib/security.lib.php
index a5347387349..5418334e559 100644
--- a/htdocs/core/lib/security.lib.php
+++ b/htdocs/core/lib/security.lib.php
@@ -27,10 +27,11 @@
 
 
 /**
- *	Encode a string
+ *	Encode a string with base 64 algorithm + specific change
+ *	Code of this function is useless and we should use base64_encode only instead
  *
- *	@param   string		$chain		chaine de caracteres a encoder
- *	@return  string					chaine de caracteres encodees
+ *	@param   string		$chain		string to encode
+ *	@return  string					encoded string
  */
 function dol_encode($chain)
 {
@@ -45,10 +46,12 @@ function dol_encode($chain)
 }
 
 /**
- *	Decode a string
+ *	Decode a base 64 encoded + specific string.
+ *  This function is called by filefunc.inc.php at each page call.
+ *	Code of this function is useless and we should use base64_decode only instead
  *
- *	@param   string		$chain		chaine de caracteres a decoder
- *	@return  string					chaine de caracteres decodee
+ *	@param   string		$chain		string to decode
+ *	@return  string					decoded string
  */
 function dol_decode($chain)
 {