Try to solve warning.

This commit is contained in:
Laurent Destailleur 2014-11-20 10:31:59 +01:00
parent 358ddb0abc
commit d94d7f683b

View File

@ -392,6 +392,7 @@ class Opensurveysondage extends CommonObject
function fetch_lines() function fetch_lines()
{ {
$ret=array(); $ret=array();
$sql = "SELECT id_users, nom as name, reponses FROM ".MAIN_DB_PREFIX."opensurvey_user_studs"; $sql = "SELECT id_users, nom as name, reponses FROM ".MAIN_DB_PREFIX."opensurvey_user_studs";
$sql.= " WHERE id_sondage = '".$this->db->escape($this->id_sondage)."'"; $sql.= " WHERE id_sondage = '".$this->db->escape($this->id_sondage)."'";
$resql=$this->db->query($sql); $resql=$this->db->query($sql);
@ -441,7 +442,9 @@ class Opensurveysondage extends CommonObject
* *
* @return Object[] * @return Object[]
*/ */
public function getComments() { public function getComments()
{
$comments = array();
$sql = 'SELECT id_comment, usercomment, comment'; $sql = 'SELECT id_comment, usercomment, comment';
$sql.= ' FROM '.MAIN_DB_PREFIX.'opensurvey_comments'; $sql.= ' FROM '.MAIN_DB_PREFIX.'opensurvey_comments';
@ -449,15 +452,18 @@ class Opensurveysondage extends CommonObject
$sql.= " ORDER BY id_comment"; $sql.= " ORDER BY id_comment";
$resql = $this->db->query($sql); $resql = $this->db->query($sql);
if ($resql)
{
$num_rows=$this->db->num_rows($resql); $num_rows=$this->db->num_rows($resql);
$comments = array(); if ($num_rows > 0)
{
if ($num_rows > 0) { while ($obj = $this->db->fetch_object($resql))
while ($obj = $this->db->fetch_object($resql)) { {
$comments[] = $obj; $comments[] = $obj;
} }
} }
}
return $comments; return $comments;
} }
@ -469,8 +475,8 @@ class Opensurveysondage extends CommonObject
* @param string $comment_user Comment author * @param string $comment_user Comment author
* @return boolean False in case of the query fails, true if it was successful * @return boolean False in case of the query fails, true if it was successful
*/ */
public function addComment($comment, $comment_user) { public function addComment($comment, $comment_user)
{
$sql = "INSERT INTO ".MAIN_DB_PREFIX."opensurvey_comments (id_sondage, comment, usercomment)"; $sql = "INSERT INTO ".MAIN_DB_PREFIX."opensurvey_comments (id_sondage, comment, usercomment)";
$sql.= " VALUES ('".$this->db->escape($this->id_sondage)."','".$this->db->escape($comment)."','".$this->db->escape($comment_user)."')"; $sql.= " VALUES ('".$this->db->escape($this->id_sondage)."','".$this->db->escape($comment)."','".$this->db->escape($comment_user)."')";
$resql = $this->db->query($sql); $resql = $this->db->query($sql);
@ -488,7 +494,8 @@ class Opensurveysondage extends CommonObject
* @param int $id_comment Id of the comment * @param int $id_comment Id of the comment
* @return boolean False in case of the query fails, true if it was successful * @return boolean False in case of the query fails, true if it was successful
*/ */
public function deleteComment($id_comment) { public function deleteComment($id_comment)
{
$sql = 'DELETE FROM '.MAIN_DB_PREFIX.'opensurvey_comments WHERE id_comment = '.$id_comment.' AND id_sondage = '.$this->id_sondage; $sql = 'DELETE FROM '.MAIN_DB_PREFIX.'opensurvey_comments WHERE id_comment = '.$id_comment.' AND id_sondage = '.$this->id_sondage;
$resql = $this->db->query($sql); $resql = $this->db->query($sql);
@ -504,8 +511,8 @@ class Opensurveysondage extends CommonObject
* *
* @return void * @return void
*/ */
private function cleanParameters() { private function cleanParameters()
{
$this->id_sondage = trim($this->id_sondage); $this->id_sondage = trim($this->id_sondage);
$this->commentaires = trim($this->commentaires); $this->commentaires = trim($this->commentaires);
$this->mail_admin = trim($this->mail_admin); $this->mail_admin = trim($this->mail_admin);