From e14072473826b79cd34107232989c3ff2c9b1d59 Mon Sep 17 00:00:00 2001
From: Regis Houssin <regis@dolibarr.fr>
Date: Mon, 6 Aug 2012 08:13:58 +0200
Subject: [PATCH] Fix: avoid warning

---
 htdocs/admin/const.php | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/htdocs/admin/const.php b/htdocs/admin/const.php
index a2b4ae4d909..ccd5a72c0db 100644
--- a/htdocs/admin/const.php
+++ b/htdocs/admin/const.php
@@ -28,15 +28,20 @@ require_once(DOL_DOCUMENT_ROOT."/core/lib/admin.lib.php");
 
 $langs->load("admin");
 
-if (! $user->admin) accessforbidden();
+if (! $user->admin)
+	accessforbidden();
 
 $rowid=GETPOST('rowid','int');
 $entity=GETPOST('entity','int');
-$action=GETPOST('action');
-$update=GETPOST('update');
-$delete=GETPOST('delete');
-$debug=GETPOST('debug');
+$action=GETPOST('action','alpha');
+$update=GETPOST('update','alpha');
+$delete=GETPOST('delete','alpha');
+$debug=GETPOST('debug','int');
 $consts=GETPOST('const');
+$constname=GETPOST('constname','alpha');
+$constvalue=GETPOST('constvalue');
+$constnote=GETPOST('constnote','alpha');
+$consttype=GETPOST('consttype','alpha');
 
 $typeconst=array('yesno','texte','chaine');
 $mesg='';
@@ -50,12 +55,12 @@ if ($action == 'add')
 {
 	$error=0;
 
-	if (empty($_POST["constname"]))
+	if (empty($constname))
 	{
 		$mesg='<div class="error">'.$langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv("Name")).'</div>';
 		$error++;
 	}
-	if ($_POST["constvalue"]=='')
+	if ($constvalue == '')
 	{
 		$mesg='<div class="error">'.$langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv("Value")).'</div>';
 		$error++;
@@ -63,7 +68,7 @@ if ($action == 'add')
 
 	if (! $error)
 	{
-		if (dolibarr_set_const($db, $_POST["constname"],$_POST["constvalue"],$typeconst[$_POST["consttype"]],1,isset($_POST["constnote"])?$_POST["constnote"]:'',$_POST["entity"]) < 0)
+		if (dolibarr_set_const($db, $constname, $constvalue, $typeconst[$consttype], 1, $constnote, $entity) < 0)
 		{
 			dol_print_error($db);
 		}
@@ -76,7 +81,7 @@ if (! empty($consts) && $update == $langs->trans("Modify"))
 	{
 		if (! empty($const["check"]))
 		{
-			if (dolibarr_set_const($db, $const["name"],$const["value"],$const["type"],1,$const["note"],$const["entity"]) < 0)
+			if (dolibarr_set_const($db, $const["name"], $const["value"], $const["type"], 1, $const["note"], $const["entity"]) < 0)
 			{
 				dol_print_error($db);
 			}