lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean code

Browse Source
This commit is contained in:
Laurent Destailleur 2021-06-22 17:33:33 +02:00
parent 664e64a2ba
commit ecd028d124
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
htdocs/modulebuilder/template/test/phpunit/MyObjectTest.php
View File

@ -53,7 +53,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
* Constructor * Constructor
* We save global variables into local variables * We save global variables into local variables
* *
* @return MyObject * @return MyObjectTest
*/ */
public function __construct() public function __construct()
{ {

9
test/phpunit/KnowledgeRecordTest.php
View File

@ -53,7 +53,7 @@ class KnowledgeRecordTest extends \PHPUnit\Framework\TestCase
* Constructor * Constructor
* We save global variables into local variables * We save global variables into local variables
* *
* @return KnowledgeRecord * @return KnowledgeRecordTest
*/ */
public function __construct() public function __construct()
{ {
@ -80,7 +80,9 @@ class KnowledgeRecordTest extends \PHPUnit\Framework\TestCase
global $conf, $user, $langs, $db; global $conf, $user, $langs, $db;
$db->begin(); // This is to have all actions inside a transaction even if test launched without suite. $db->begin(); // This is to have all actions inside a transaction even if test launched without suite.
print __METHOD__."\n"; if (empty($conf->knowledgemanagement->enabled)) {
// print __METHOD__." module knowledgemanagement order must be enabled.\n"; die(1);
}
} }
/** /**
@ -183,11 +185,12 @@ class KnowledgeRecordTest extends \PHPUnit\Framework\TestCase
$localobject = new KnowledgeRecord($this->savdb); $localobject = new KnowledgeRecord($this->savdb);
$result = $localobject->fetch($id); $result = $localobject->fetch($id);
print __METHOD__." id=".$id." result=".$result."\n";
$this->assertGreaterThanOrEqual(0, $result, 'fetch in testKnowledgeRecordDelete with id='.$id); $this->assertGreaterThanOrEqual(0, $result, 'fetch in testKnowledgeRecordDelete with id='.$id);
$result = $localobject->delete($user); $result = $localobject->delete($user);
print __METHOD__." id=".$id." result=".$result."\n"; print __METHOD__." result=".$result."\n";
$this->assertGreaterThanOrEqual(0, $result, 'delete in testKnowledgeRecordDelete'); $this->assertGreaterThanOrEqual(0, $result, 'delete in testKnowledgeRecordDelete');
return $result; return $result;
} }