From f837845c122840182ca1f52e0f5a50066accbc70 Mon Sep 17 00:00:00 2001
From: Marc de Lima Lucio <68746600+marc-dll@users.noreply.github.com>
Date: Tue, 8 Mar 2022 15:07:02 +0100
Subject: [PATCH] FIX: still prevent project creation if PROJECTLEADER role
 unavailable, but with a specific error message

---
 htdocs/langs/en_US/projects.lang | 3 ++-
 htdocs/projet/card.php           | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/htdocs/langs/en_US/projects.lang b/htdocs/langs/en_US/projects.lang
index 2aedbd53377..d93bbbe4a9d 100644
--- a/htdocs/langs/en_US/projects.lang
+++ b/htdocs/langs/en_US/projects.lang
@@ -267,4 +267,5 @@ NewInvoice=New invoice
 OneLinePerTask=One line per task
 OneLinePerPeriod=One line per period
 RefTaskParent=Ref. Parent Task
-ProfitIsCalculatedWith=Profit is calculated using
\ No newline at end of file
+ProfitIsCalculatedWith=Profit is calculated using
+ErrorPROJECTLEADERRoleMissingOrDeActivatedPleaseRestoreItInContactTypesDictionary=The "PROJECTLEADER" role is missing or has been de-activited, please restore in the dictionary of contact types
\ No newline at end of file
diff --git a/htdocs/projet/card.php b/htdocs/projet/card.php
index ab61a613734..8c921c0868e 100644
--- a/htdocs/projet/card.php
+++ b/htdocs/projet/card.php
@@ -178,7 +178,10 @@ if (empty($reshook))
 				$result = $object->add_contact($user->id, $typeofcontact, 'internal');
 
 				// -3 means type not found (PROJECTLEADER renamed, de-activated or deleted), so don't prevent creation if it has been the case
-				if ($result < 0 && $result != -3) {
+				if ($result == -3) {
+					setEventMessage('ErrorPROJECTLEADERRoleMissingOrDeActivatedPleaseRestoreItInContactTypesDictionary', 'errors');
+                    $error++;
+				} elseif ($result < 0) {
 					$langs->load("errors");
 					setEventMessages($object->error, $object->errors, 'errors');
 					$error++;