lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean code

Browse Source
This commit is contained in:
Laurent Destailleur 2020-11-30 13:22:48 +01:00
parent 379bca0b61
commit fa8b960520
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
htdocs/product/admin/price_rules.php
View File

@ -26,15 +26,18 @@ require_once DOL_DOCUMENT_ROOT.'/core/lib/product.lib.php';
// Load translation files required by the page // Load translation files required by the page
$langs->loadLangs(array('admin', 'products')); $langs->loadLangs(array('admin', 'products'));
$action = GETPOST('action', 'aZ09');
// Security check // Security check
if (!$user->admin || (empty($conf->product->enabled) && empty($conf->service->enabled))) if (!$user->admin || (empty($conf->product->enabled) && empty($conf->service->enabled)))
accessforbidden(); accessforbidden();
/** /**
* Actions * Actions
*/ */
if ($_POST) { if ($action == 'update') {
$var_percent = GETPOST('var_percent', 'array'); $var_percent = GETPOST('var_percent', 'array');
$var_min_percent = GETPOST('var_min_percent', 'array'); $var_min_percent = GETPOST('var_min_percent', 'array');
$fk_level = GETPOST('fk_level', 'array'); $fk_level = GETPOST('fk_level', 'array');
@ -70,19 +73,19 @@ if ($_POST) {
if (!$check1 || !$check2) { if (!$check1 || !$check2) {
//If the level is between range but percent fields are empty, then we ensure it does not exist in DB //If the level is between range but percent fields are empty, then we ensure it does not exist in DB
if ($check1) { if ($check1) {
$db->query("DELETE FROM ".MAIN_DB_PREFIX."product_pricerules WHERE level = ".(int) $i); $db->query("DELETE FROM ".MAIN_DB_PREFIX."product_pricerules WHERE level = ".((int) $i));
} }
continue; continue;
} }
$sql = "INSERT INTO ".MAIN_DB_PREFIX."product_pricerules (level, fk_level, var_percent, var_min_percent) VALUES ( $sql = "INSERT INTO ".MAIN_DB_PREFIX."product_pricerules (level, fk_level, var_percent, var_min_percent) VALUES (";
".(int) $i.", ".$db->escape($i_fk_level).", ".$i_var_percent.", ".$i_var_min_percent.")"; $sql .= ((int) $i).", ".$db->escape($i_fk_level).", ".$i_var_percent.", ".$i_var_min_percent.")";
if (!$db->query($sql)) { if (!$db->query($sql)) {
//If we could not create, then we try updating //If we could not create, then we try updating
$sql = "UPDATE ".MAIN_DB_PREFIX."product_pricerules $sql = "UPDATE ".MAIN_DB_PREFIX."product_pricerules";
SET fk_level = ".$db->escape($i_fk_level).", var_percent = ".$i_var_percent.", var_min_percent = ".$i_var_min_percent." WHERE level = ".$i; $sql .= " SET fk_level = ".$db->escape($i_fk_level).", var_percent = ".$i_var_percent.", var_min_percent = ".$i_var_min_percent." WHERE level = ".$i;
if (!$db->query($sql)) { if (!$db->query($sql)) {
setEventMessages($langs->trans('ErrorSavingChanges'), null, 'errors'); setEventMessages($langs->trans('ErrorSavingChanges'), null, 'errors');
@ -93,6 +96,7 @@ if ($_POST) {
setEventMessages($langs->trans("RecordSaved"), null, 'mesgs'); setEventMessages($langs->trans("RecordSaved"), null, 'mesgs');
} }
/* /*
* View * View
*/ */
@ -124,8 +128,9 @@ $linkback = '<a href="'.DOL_URL_ROOT.'/admin/modules.php?restore_lastsearch_valu
print load_fiche_titre($title, $linkback, 'title_setup'); print load_fiche_titre($title, $linkback, 'title_setup');
print '<form method="POST" action="'.$_SERVER["PHP_SELF"].'">';
print '<form method="POST">'; print '<input type="hidden" name="token" value="'.newToken().'">';
print '<input type="hidden" name="action" value="update">';
$head = product_admin_prepare_head(); $head = product_admin_prepare_head();
print dol_get_fiche_head($head, 'generator', $tab, 0, 'product'); print dol_get_fiche_head($head, 'generator', $tab, 0, 'product');