lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix regression when disabling table

Browse Source
This commit is contained in:
Laurent Destailleur 2018-12-10 00:15:22 +01:00
parent 930312b425
commit ff8f235b7e
1 changed files with 26 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
htdocs/ticket/class/ticket.class.php
View File

@ -898,11 +898,6 @@ class Ticket extends CommonObject
if ($res < 0) $error++; if ($res < 0) $error++;
} }
if (!$error) {
$sql = "DELETE FROM " . MAIN_DB_PREFIX . "ticket_logs";
$sql .= " WHERE fk_track_id = '" . $this->db->escape($this->track_id) . "'";
$resql = $this->db->query($sql);
}
if (!$error) { if (!$error) {
$sql = "DELETE FROM " . MAIN_DB_PREFIX . "ticket_msg"; $sql = "DELETE FROM " . MAIN_DB_PREFIX . "ticket_msg";
$sql .= " WHERE fk_track_id = '" . $this->db->escape($this->track_id) . "'"; $sql .= " WHERE fk_track_id = '" . $this->db->escape($this->track_id) . "'";
@ -1496,6 +1491,8 @@ class Ticket extends CommonObject
{ {
global $conf, $langs; global $conf, $langs;
$error = 0;
$this->db->begin(); $this->db->begin();
// Clean parameters // Clean parameters
@ -1507,36 +1504,22 @@ class Ticket extends CommonObject
return -1; return -1;
} }
// Insert request // TODO Should call the trigger TICKET_MODIFY with $this->context with all data to record event
$sql = "INSERT INTO " . MAIN_DB_PREFIX . "ticket_logs("; // so the event is stored by the agenda/event trigger
$sql .= "entity,";
$sql .= "datec,"; if (!$error) {
$sql .= "fk_track_id,"; $this->db->commit();
$sql .= "fk_user_create,";
$sql .= "message";
$sql .= ") VALUES (";
$sql .= " " . $conf->entity . ",";
$sql .= " '" . $this->db->idate(dol_now()) . "',";
$sql .= " '" . $this->db->escape($this->track_id) . "',";
$sql .= " " . ($user->id > 0 ? $user->id : 'NULL') . ",";
$sql .= " '" . $this->db->escape($message) . "'";
$sql .= ")";
dol_syslog(get_class($this) . "::create_ticket_log sql=" . $sql, LOG_DEBUG);
$resql = $this->db->query($sql);
if ($resql) {
if ($conf->global->TICKET_ACTIVATE_LOG_BY_EMAIL && !$noemail) { if ($conf->global->TICKET_ACTIVATE_LOG_BY_EMAIL && !$noemail) {
$this->sendLogByEmail($user, $message); $this->sendLogByEmail($user, $message);
} }
if (!$error) {
$this->db->commit();
return 1; return 1;
} }
} else { else
{
$this->db->rollback(); $this->db->rollback();
$this->error = "Error " . $this->db->lasterror();
dol_syslog(get_class($this) . "::create_ticket_log " . $this->error, LOG_ERR);
return -1; return -1;
} }
} }
@ -1647,6 +1630,8 @@ class Ticket extends CommonObject
} }
// Cache deja charge // Cache deja charge
// TODO Read the table llx_actioncomm
/*
$sql = "SELECT rowid, fk_user_create, datec, message"; $sql = "SELECT rowid, fk_user_create, datec, message";
$sql .= " FROM " . MAIN_DB_PREFIX . "ticket_logs"; $sql .= " FROM " . MAIN_DB_PREFIX . "ticket_logs";
$sql .= " WHERE fk_track_id ='" . $this->db->escape($this->track_id) . "'"; $sql .= " WHERE fk_track_id ='" . $this->db->escape($this->track_id) . "'";
@ -1669,7 +1654,9 @@ class Ticket extends CommonObject
$this->error = "Error " . $this->db->lasterror(); $this->error = "Error " . $this->db->lasterror();
dol_syslog(get_class($this) . "::loadCacheLogsTicket " . $this->error, LOG_ERR); dol_syslog(get_class($this) . "::loadCacheLogsTicket " . $this->error, LOG_ERR);
return -1; return -1;
} }*/
return 0;
} }
/** /**