Merge pull request #21013 from atm-greg/FIX_12.0_get_batch_only_for_same_fk_product

fix sql to avoid getting product_stock of another product with same batch
Update productbatch.class.php
2022-05-24 21:23:02 +02:00 · 2022-05-24 21:22:14 +02:00 · 2022-05-24 16:49:55 +02:00
1 changed files with 3 additions and 3 deletions
--- a/htdocs/product/class/productbatch.class.php
+++ b/htdocs/product/class/productbatch.class.php
@ -531,11 +531,11 @@ class Productbatch extends CommonObject
 		$sql .= " FROM ".MAIN_DB_PREFIX."product_lot as pl";
 		$sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product as p ON p.rowid = pl.fk_product";
 		$sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_batch AS pb ON pl.batch = pb.batch";
-		$sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_stock AS ps ON ps.rowid = pb.fk_product_stock";
+		$sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_stock AS ps ON ps.rowid = pb.fk_product_stock AND ps.fk_product = ".((int) $fk_product);
 		$sql .= " WHERE p.entity IN (".getEntity('product').")";
-		$sql .= " AND pl.fk_product = ".$fk_product;
+		$sql .= " AND pl.fk_product = ".((int) $fk_product);
 		if ($fk_warehouse > 0) {
-			$sql .= " AND ps.fk_entrepot = ".$fk_warehouse;
+			$sql .= " AND ps.fk_entrepot = ".((int) $fk_warehouse);
 		}
 		if ($qty_min !== null) {
 			$sql .= " AND pb.qty > ".$qty_min;
Author	SHA1	Message	Date
Laurent Destailleur	192510316b	Merge pull request #21013 from atm-greg/FIX_12.0_get_batch_only_for_same_fk_product fix sql to avoid getting product_stock of another product with same batch	2022-05-24 21:23:02 +02:00
Laurent Destailleur	6f83c8c6f3	Update productbatch.class.php	2022-05-24 21:22:14 +02:00
atm-greg	8213756c37	fix sql to avoid getting product_stock of another product with same batch	2022-05-24 16:49:55 +02:00