Small correction but unable to make loan payment

This commit is contained in:
frederic34 2015-03-28 15:31:09 +01:00
parent 7282a6faf2
commit af92174ae2
5 changed files with 26 additions and 23 deletions

View File

@ -13,10 +13,11 @@ LoanAccountancyInsuranceCode=Accountancy code insurance
LoanAccountancyInterestCode=Accountancy code interest LoanAccountancyInterestCode=Accountancy code interest
LoanPayment=Loan payment LoanPayment=Loan payment
ConfirmDeleteLoan=Confirm deleting this loan ConfirmDeleteLoan=Confirm deleting this loan
LoanDeleted=Loan Deleted Successfully
ConfirmPayLoan=Confirm classify paid this loan ConfirmPayLoan=Confirm classify paid this loan
ErrorLoanCapital=<font color=red>Loan amount</font> has to be numeric and greater than zero. ErrorLoanCapital=Loan amount has to be numeric and greater than zero.
ErrorLoanLength=<font color=red>Loan length</font> has to be numeric and greater than zero. ErrorLoanLength=Loan length has to be numeric and greater than zero.
ErrorLoanInterest=<font color=red>Annual interest</font> has to be numeric and greater than zero. ErrorLoanInterest=Annual interest has to be numeric and greater than zero.
# Calc # Calc
LoanCalc=Bank Loans Calculator LoanCalc=Bank Loans Calculator
PurchaseFinanceInfo=Purchase & Financing Information PurchaseFinanceInfo=Purchase & Financing Information

View File

@ -61,6 +61,7 @@ if ($action == 'confirm_delete' && $confirm == 'yes')
$result=$object->delete($user); $result=$object->delete($user);
if ($result > 0) if ($result > 0)
{ {
setEventMessage($langs->trans('LoanDeleted'));
header("Location: index.php"); header("Location: index.php");
exit; exit;
} }
@ -129,7 +130,7 @@ else if ($action == 'update' && $user->rights->loan->write)
if (! $cancel) if (! $cancel)
{ {
$result = $object->fetch($id); $result = $object->fetch($id);
if ($object->fetch($id)) if ($object->fetch($id))
{ {
$object->label = GETPOST("label"); $object->label = GETPOST("label");
@ -475,25 +476,25 @@ if ($id > 0)
// Edit // Edit
if ($user->rights->loan->write) if ($user->rights->loan->write)
{ {
print "<a class=\"butAction\" href=\"".DOL_URL_ROOT."/loan/card.php?id=$object->id&amp;action=edit\">".$langs->trans("Modify")."</a>"; print '<a class="butAction" href="'.DOL_URL_ROOT.'/loan/card.php?id='.$object->id.'&amp;action=edit">'.$langs->trans("Modify").'</a>';
} }
// Emit payment // Emit payment
if ($object->paid == 0 && ((price2num($object->capital) > 0 && round($staytopay) < 0) || (price2num($object->capital) > 0 && round($staytopay) > 0)) && $user->rights->loan->write) if ($object->paid == 0 && ((price2num($object->capital) > 0 && round($staytopay) < 0) || (price2num($object->capital) > 0 && round($staytopay) > 0)) && $user->rights->loan->write)
{ {
print "<a class=\"butAction\" href=\"".DOL_URL_ROOT."/loan/payment/payment.php?id=$object->id&amp;action=create\">".$langs->trans("DoPayment")."</a>"; print '<a class="butAction" href="'.DOL_URL_ROOT.'/loan/payment/payment.php?id='.$object->id.'&amp;action=create">'.$langs->trans("DoPayment").'</a>';
} }
// Classify 'paid' // Classify 'paid'
if ($object->paid == 0 && round($staytopay) <=0 && $user->rights->loan->write) if ($object->paid == 0 && round($staytopay) <=0 && $user->rights->loan->write)
{ {
print "<a class=\"butAction\" href=\"".DOL_URL_ROOT."/loan/card.php?id=$object->id&amp;action=paid\">".$langs->trans("ClassifyPaid")."</a>"; print '<a class="butAction" href="'.DOL_URL_ROOT.'/loan/card.php?id='.$object->id.'&amp;action=paid">'.$langs->trans("ClassifyPaid").'</a>';
} }
// Delete // Delete
if ($user->rights->loan->delete) if ($user->rights->loan->delete)
{ {
print "<a class=\"butActionDelete\" href=\"".DOL_URL_ROOT."/loan/card.php?id=$object->id&amp;action=delete\">".$langs->trans("Delete")."</a>"; print '<a class="butActionDelete" href="'.DOL_URL_ROOT.'/loan/card.php?id='.$object->id.'&amp;action=delete">'.$langs->trans("Delete").'</a>';
} }
print "</div>"; print "</div>";

View File

@ -119,7 +119,7 @@ class PaymentLoan extends CommonObject
$sql.= " VALUES (".$this->chid.", '".$this->db->idate($now)."',"; $sql.= " VALUES (".$this->chid.", '".$this->db->idate($now)."',";
$sql.= " '".$this->db->idate($this->datepaid)."',"; $sql.= " '".$this->db->idate($this->datepaid)."',";
$sql.= " ".$totalamount.","; $sql.= " ".$totalamount.",";
$sql.= " ".$this->paymenttype.", '".$this->db->escape($this->num_payment)."', '".$this->db->escape($this->note_private)."', ".$this->db->escape($this->note_public)."', ".$user->id.","; $sql.= " ".$this->paymenttype.", '".$this->db->escape($this->num_payment)."', '".$this->db->escape($this->note_private)."', '".$this->db->escape($this->note_public)."', ".$user->id.",";
$sql.= " 0)"; $sql.= " 0)";
dol_syslog(get_class($this)."::create", LOG_DEBUG); dol_syslog(get_class($this)."::create", LOG_DEBUG);
@ -130,6 +130,7 @@ class PaymentLoan extends CommonObject
} }
else else
{ {
$this->error=$this->db->lasterror();
$error++; $error++;
} }

View File

@ -31,7 +31,7 @@ $langs->load("banks");
$langs->load("bills"); $langs->load("bills");
// Security check // Security check
$socid = isset($_GET["socid"])?$_GET["socid"]:''; $socid = GETPOST('socid', int);
if ($user->societe_id) $socid=$user->societe_id; if ($user->societe_id) $socid=$user->societe_id;
$result = restrictedArea($user, 'loan', '', '', ''); $result = restrictedArea($user, 'loan', '', '', '');

View File

@ -56,21 +56,21 @@ if ($action == 'add_payment')
exit; exit;
} }
$datepaid = dol_mktime(12, 0, 0, $_POST["remonth"], $_POST["reday"], $_POST["reyear"]); $datepaid = dol_mktime(12, 0, 0, GETPOST('remonth', 'int'), GETPOST('reday', 'int'), GETPOST('reyear', 'int'));
if (! $_POST["paymenttype"] > 0) if (! $_POST["paymenttype"] > 0)
{ {
$mesg = $langs->trans("ErrorFieldRequired",$langs->transnoentities("PaymentMode")); setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("PaymentMode")), 'errors');
$error++; $error++;
} }
if ($datepaid == '') if ($datepaid == '')
{ {
$mesg = $langs->trans("ErrorFieldRequired",$langs->transnoentities("Date")); setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("Date")), 'errors');
$error++; $error++;
} }
if (! empty($conf->banque->enabled) && ! $_POST["accountid"] > 0) if (! empty($conf->banque->enabled) && ! $_POST["accountid"] > 0)
{ {
$mesg = $langs->trans("ErrorFieldRequired",$langs->transnoentities("AccountToCredit")); setEventMessage($langs->trans("ErrorFieldRequired",$langs->transnoentities("AccountToCredit")), 'errors');
$error++; $error++;
} }
@ -90,8 +90,8 @@ if ($action == 'add_payment')
if (count($amounts) <= 0) if (count($amounts) <= 0)
{ {
setEventMessage($langs->trans('ErrorNoPaymentDefined'), 'errors');
$error++; $error++;
$errmsg='ErrorNoPaymentDefined';
} }
if (! $error) if (! $error)
@ -103,11 +103,11 @@ if ($action == 'add_payment')
$payment->chid = $chid; $payment->chid = $chid;
$payment->datepaid = $datepaid; $payment->datepaid = $datepaid;
$payment->amounts = $amounts; // Tableau de montant $payment->amounts = $amounts; // Tableau de montant
$payment->amount_capital = $_POST["amount_capital"]; $payment->amount_capital = GETPOST('amount_capital');
$payment->amount_insurance = $_POST["amount_insurance"]; $payment->amount_insurance = GETPOST('amount_insurance');
$payment->amount_interest = $_POST["amount_interest"]; $payment->amount_interest = GETPOST('amount_interest');
$payment->paymenttype = $_POST["paymenttype"]; $payment->paymenttype = GETPOST('paymenttype');
$payment->num_payment = $_POST["num_payment"]; $payment->num_payment = GETPOST('num_payment');
$payment->note_private = GETPOST('note_private'); $payment->note_private = GETPOST('note_private');
$payment->note_public = GETPOST('note_public'); $payment->note_public = GETPOST('note_public');
@ -116,17 +116,17 @@ if ($action == 'add_payment')
$paymentid = $payment->create($user); $paymentid = $payment->create($user);
if ($paymentid < 0) if ($paymentid < 0)
{ {
$errmsg=$payment->error; setEventMessage($payment->error, 'errors');
$error++; $error++;
} }
} }
if (! $error) if (! $error)
{ {
$result=$payment->addPaymentToBank($user,'payment_loan','(LoanPayment)',$_POST['accountid'],'',''); $result=$payment->addPaymentToBank($user, 'payment_loan', '(LoanPayment)', GETPOST('accountid', 'int'), '', '');
if (! $result > 0) if (! $result > 0)
{ {
$errmsg=$payment->error; setEventMessage($payment->error, 'errors');
$error++; $error++;
} }
} }